Commit 6d344fc0ddcc

Vincent Demeester <vincent@sbr.pm>
2026-01-27 11:06:08
fix(gh-pr): ignore untracked files and require tool in workflow
Update gh-pr to latest which fixes the issue where untracked files would cause PR creation to fail unnecessarily. Also update CreatePR workflow to make gh-pr usage required instead of just recommended, with fallback only for exceptional cases. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
1 parent f52fe4c
Changed files (2)
dots
.config
claude
skills
GitHub
workflows
pkgs
dots/.config/claude/skills/GitHub/workflows/CreatePR.md
@@ -9,9 +9,9 @@ Create a GitHub pull request with validations, auto-push, and template support.
 - "new pr"
 - "submit changes"
 
-## Recommended Tool: gh-pr create
+## Required: Use gh-pr create
 
-Use the `gh-pr create` command for a streamlined experience with built-in validations.
+**Always use `gh-pr create`** - it provides built-in validations and template support that ensure consistent PR quality.
 
 ```bash
 # Basic usage - validates branch, pushes, then creates PR
@@ -61,25 +61,21 @@ The tool automatically:
 4. **Detects remote**: Uses personal fork remote if available
 5. **Loads templates**: Discovers and uses PR templates
 
-## Alternative: Direct gh CLI
+## Fallback: Direct gh CLI (Exceptional Cases Only)
 
-For basic usage without validations:
+Only use `gh pr create` directly when `gh-pr create` cannot be used (e.g., untracked files blocking validation, cross-fork PRs to different upstream). In these cases, you must manually ensure:
+- Not on main/master branch
+- Branch is pushed to remote
+- PR template is properly filled
 
 ```bash
-# Interactive PR creation
-gh pr create
-
-# Fill from commit messages
-gh pr create --fill
-
-# With all options
+# Cross-fork PR (gh-pr doesn't support --repo flag)
 gh pr create \
+  --repo upstream/repo \
+  --base main \
+  --head yourname:feature-branch \
   --title "feat: Add feature" \
-  --body "Description" \
-  --reviewer @user1 \
-  --assignee @me \
-  --label enhancement \
-  --draft
+  --body "$(cat .github/pull_request_template.md)"
 ```
 
 ## Workflow Steps (Manual)
@@ -160,15 +156,6 @@ gh-pr create
 gh-pr create --draft -t "WIP: New feature"
 ```
 
-### Cross-Fork PR
-
-```bash
-gh pr create \
-  --repo upstream/repo \
-  --base main \
-  --head yourname:feature-branch
-```
-
 ### Require Signed Commits
 
 ```bash
pkgs/gh-pr/default.nix
@@ -16,8 +16,8 @@ buildGoModule rec {
   src = fetchFromGitHub {
     owner = "vdemeester";
     repo = "x";
-    rev = "553c2e048e1a31014c2bffad7b1941813a1b5c4e";
-    hash = "sha256-NR7XtMFVtMjt+4tmWuqP9TTe5FUaobhXNkYHrxaZJyU=";
+    rev = "b6a0923d827a562731a4a88ef505331205f8bead";
+    hash = "sha256-qhgL79lIg3ohf8EawiTUd9B5Ntk8uBsX1iXcyVmAnBY=";
   };
 
   vendorHash = "sha256-hocnLCzWN8srQcO3BMNkd2lt0m54Qe7sqAhUxVZlz1k=";